From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Tue, 25 May 2021 16:16:08 +0200 Subject: [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test In-Reply-To: References: <20190911124714.GA21670@rei.lan> <1571975625-6322-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > > stx_attributes_mask shows what's supported in stx_attributes. > > Set supp_{append,compr,immutable,nodump} attributes only on filesystems > > which actually support it. > > > > Also merge duplicate code. > > > > --------------- > > v2->v3: > > 1.add kernel version check for stx_attributes_mask > > 2. use test_flag(int) instead of test_flagged and test_unflagged > > --------------- > > > > Signed-off-by: Yang Xu > > Reviewed-by: Petr Vorel > > Reviewed-by: Li Wang > > This patch makes sense to me, I'm not sure if any blocker issue for > holding the apply process. If _no_ I would help to merge it:). See: https://github.com/linux-test-project/ltp/issues/557 Basically this change hides a kernel bug. I've proposed to create a separate test for kernel that makes sure that all flags that are supposed to be enabled are enabled for new enough kernels, then we can apply this patch. -- Cyril Hrubis chrubis@suse.cz