From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] nfs_lib.sh: Check running rpc.mountd, rpcbind/portmap
Date: Wed, 26 May 2021 09:18:35 +0200 [thread overview]
Message-ID: <YK32S7sPQdxf3NO2@pevik> (raw)
In-Reply-To: <20210525135012.877-2-pvorel@suse.cz>
Hi Alexey,
> Both are required to be running for NFS tests.
> This requires to add pgrep dependency, as we don't have custom LTP C
> based tool for searching in processes.
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index 1bd057717..25fe67bda 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -27,7 +27,7 @@ TST_PARSE_ARGS=nfs_parse_args
> TST_USAGE=nfs_usage
> TST_NEEDS_TMPDIR=1
> TST_NEEDS_ROOT=1
> -TST_NEEDS_CMDS="$TST_NEEDS_CMDS mount exportfs"
> +TST_NEEDS_CMDS="$TST_NEEDS_CMDS exportfs mount pgrep"
> TST_SETUP="${TST_SETUP:-nfs_setup}"
> TST_CLEANUP="${TST_CLEANUP:-nfs_cleanup}"
> @@ -107,6 +107,11 @@ nfs_setup()
> tst_brk TCONF "Cannot run nfs-stress test on mounted NFS"
> fi
> + pgrep rpc.mountd > /dev/null || \
> + tst_brk TCONF "rpc.mountd not running"
> +
> + check_portmap_rpcbind
I found that at least some tests (e.g. nfs01) runs with stopped rpcbind.
I suppose that's because nfs-server.service is able to restart it
(it's activated via socket).
Although rpc.mountd (nfs-mountd.service) is required, nfs-mountd.service is a
nfs-server.service dependency (nfs-server.service:Requires=nfs-mountd.service).
Thus it's probably enough to check that rpc.nfsd is running.
=> sending v2 with just single commit.
Kind regards,
Petr
next prev parent reply other threads:[~2021-05-26 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 13:50 [LTP] [PATCH 1/3] tst_net.sh: Move check_portmap_rpcbind() + fixes Petr Vorel
2021-05-25 13:50 ` [LTP] [PATCH 2/3] nfs_lib.sh: Check running rpc.mountd, rpcbind/portmap Petr Vorel
2021-05-26 7:18 ` Petr Vorel [this message]
2021-05-25 13:50 ` [LTP] [PATCH 3/3] nfs_lib.sh: Print verbose mount info on error Petr Vorel
2021-05-25 16:31 ` Alexey Kodanev
2021-05-26 7:11 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK32S7sPQdxf3NO2@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox