public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] network/lib6/getaddrinfo01: rewrite with the new API + use static hostnames
Date: Tue, 18 May 2021 11:59:01 +0200	[thread overview]
Message-ID: <YKOP5cWttVUANr0i@yuki> (raw)
In-Reply-To: <235d2495-92af-7638-c468-9456dd202296@bell-sw.com>

Hi!
> >> The test is now independent of various machine settings
> >> regarding the test host name as it adds predefined names
> >> and aliases to /etc/hosts file and restores it to its
> >> original state after completing the test.
> > 
> >> This should fix the following failures:
> >> * when gethostname() returns an alias name that doesn't
> >>   match canonical name;
> >> * No AAAA record for the returned name from gethostname().
> > 
> >> Addresses and names added to /etc/hosts are more or less
> >> unique, so that there are no conflicts with the existing
> >> configuration.
> > 
> >> Also most of the duplicate code is now gone.
> > 
> > Thanks a lot. On a first look looks very nice, I'll try to review tomorrow.
> > I'd be for merging this before release as the old code is broken.
> 
> Yeah, I'm for it too.

I would be a bit more cautious now as it's fairly late in the release
process. We already started pre-release testing and got some reports in.
Merging this would invalidate results for this test and would require
re-testing.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-05-18  9:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  8:56 [LTP] [PATCH] network/lib6/getaddrinfo01: rewrite with the new API + use static hostnames Alexey Kodanev
2021-05-17 19:57 ` Petr Vorel
2021-05-18 10:19   ` Alexey Kodanev
2021-05-18  9:59     ` Cyril Hrubis [this message]
2021-05-18  6:02 ` Petr Vorel
2021-05-18  8:30   ` Alexey Kodanev
2021-05-18 15:25     ` Petr Vorel
  -- strict thread matches above, loose matches on Subject: below --
2021-05-18  9:14 Alexey Kodanev
2021-05-18 19:15 ` Petr Vorel
2021-05-19  7:32   ` Alexey Kodanev
2021-05-19 19:59     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKOP5cWttVUANr0i@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox