From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] network/lib6/getaddrinfo01: rewrite with the new API + use static hostnames
Date: Tue, 18 May 2021 17:20:29 +0200 [thread overview]
Message-ID: <YKPbPXy113n/5IFo@pevik> (raw)
In-Reply-To: <f584f853-c13c-cc16-8e75-085af0b82418@bell-sw.com>
Hi Alexey,
> On 18.05.2021 12:14, Alexey Kodanev wrote:
> > The test is now independent of various machine settings
> > regarding the test host name as it adds predefined names
> > and aliases to /etc/hosts file and restores it to its
> > original state after completing the test.
> > This should fix the following failures:
> > * when gethostname() returns an alias name that doesn't
> > match canonical name;
> > * No AAAA record for the returned name from gethostname().
> > Addresses and names added to /etc/hosts are more or less
> > unique, so that there are no conflicts with the existing
> > configuration.
> > Also most of the duplicate code is now gone.
> > Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > ---
> Adding missing v2 update suggested by Petr:
> * description tag
> * new check_addrinfo_badflags(const char *) to remove even more code
> duplication.
Nice, thanks!
I've tested it in various distros running and compiling (+ it actually fixes
configuration bug, ...) but understand Cyril's concern about breakage last
minute before release. So we should probably merge after the release.
Kind regards,
Petr
next prev parent reply other threads:[~2021-05-18 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 9:14 [LTP] [PATCH] network/lib6/getaddrinfo01: rewrite with the new API + use static hostnames Alexey Kodanev
2021-05-18 9:22 ` [LTP] [PATCH v2] " Alexey Kodanev
2021-05-18 15:20 ` Petr Vorel [this message]
2021-05-18 19:15 ` [LTP] [PATCH] " Petr Vorel
2021-05-19 7:32 ` Alexey Kodanev
2021-05-19 19:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKPbPXy113n/5IFo@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox