public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] sendfile0{2,9}: Remove OFF_T workaround
Date: Fri, 28 May 2021 12:01:36 +0200	[thread overview]
Message-ID: <YLC/gApc5oJ9noMW@pevik> (raw)
In-Reply-To: <YLCddN29evt3O5jw@yuki>

Hi Cyril,

> Hi!
> > Using OFF_T definition to off64_t for 64bit variants seems to be am old
> > workaround for buggy libc. Nowadays we can rely on off_t to have correct size
> > (i.e.: 32bit: 4 bytes; 64bit or 32bit with -D_FILE_OFFSET_BITS=64: 8 bytes)

> Looks good to me, Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> > Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > NOTE: -DOFF_T=off64_t is also defined in testcases/kernel/io/disktest
> > and mentioned in {tst_,}safe_macros.h.

> We should remove the -DOFF_T=off64_t comment from the *safe_macros.h and
> keep only the _FILE_OFFSET_BITS there.

Good. OK, after I solve our CI (github actions) I'll merge this and send another
patch which removes it in testcases/kernel/io/disktest + the comment in
*safe_macros.h.

Thanks for review and hints!

Kind regards,
Petr

  reply	other threads:[~2021-05-28 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 10:46 [LTP] [PATCH 1/1] sendfile0{2,9}: Remove OFF_T workaround Petr Vorel
2021-05-28  7:36 ` Cyril Hrubis
2021-05-28 10:01   ` Petr Vorel [this message]
2021-06-02 11:51     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLC/gApc5oJ9noMW@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox