From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] network/busy_poll: Remove unnecessary driver check
Date: Tue, 1 Jun 2021 10:22:47 +0200 [thread overview]
Message-ID: <YLXuV//RKGTO2Ics@pevik> (raw)
In-Reply-To: <20210531135314.5067-2-mdoucha@suse.cz>
Hi Martin,
> Kernel v4.5 extended the busy_poll functionality to all network drivers.
> Limiting the test only to drivers which implemented busy_poll as internal
> feature on older kernels does not make sense.
Ah, you mean 85c72ba1ed0c ("Merge branch 'net-generic-busy-polling'")
Good catch, thx!!
Fixes: ead28f929 ("busy_poll: skip busy_poll flag test on kernels 4.5+")
Kind regards,
Petr
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> testcases/network/busy_poll/busy_poll_lib.sh | 4 ----
> 1 file changed, 4 deletions(-)
> diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh
> index 5270a1bbd..d17504466 100755
> --- a/testcases/network/busy_poll/busy_poll_lib.sh
> +++ b/testcases/network/busy_poll/busy_poll_lib.sh
> @@ -25,9 +25,5 @@ busy_poll_check_config()
> ethtool --show-features $(tst_iface) | \
> grep -q 'busy-poll.*on' || \
> tst_brk TCONF "busy poll not supported by driver"
> - else
> - drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio"
> - ethtool -i $(tst_iface) | grep -qE "driver: ($drvs)" || \
> - tst_brk TCONF "busy poll not supported"
> fi
> }
next prev parent reply other threads:[~2021-06-01 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 13:53 [LTP] [PATCH 1/2] network/busy_poll: Fix tests in namespaced env Martin Doucha
2021-05-31 13:53 ` [LTP] [PATCH 2/2] network/busy_poll: Remove unnecessary driver check Martin Doucha
2021-06-01 8:22 ` Petr Vorel [this message]
2021-06-01 8:48 ` [LTP] [PATCH 1/2] network/busy_poll: Fix tests in namespaced env Alexey Kodanev
2021-06-01 9:00 ` Petr Vorel
2021-06-01 9:03 ` Martin Doucha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLXuV//RKGTO2Ics@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox