From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/2] Libclang based analyzer
Date: Fri, 4 Jun 2021 08:20:16 +0200 [thread overview]
Message-ID: <YLnGIJWPf2XsAdTt@pevik> (raw)
In-Reply-To: <20210603154825.30165-1-rpalethorpe@suse.com>
Hi Richie,
> Hello,
> This implements a TEST() check and integrates the check into the build
> system.
> Compared to the Coccinelle version it's very ugly. However I think
> this will allow us to get all the low hanging fruit without creating
> major problems for test developers.
> I guess it could be run during CI if we either fix all the existing
> TEST() usages in the library or add an ignore list. I already have a
> Coccinelle script to help with the former.
+1.
FYI yesterday I sent patch to add make check{,-c,shell}, but for running C/shell API tests:
https://patchwork.ozlabs.org/project/ltp/list/?series=247103
Taking 2 latests commits + adding clang-devel / libclang-dev packages makes CI
running.
https://github.com/pevik/ltp/commit/b2427f39ddb15c97761208a605637e0da6fe66ca
The only missing piece is include/mk/clang-checks.mk (this patchset not even
compile now).
> Richard Palethorpe (2):
> Add 'make checks' and clang-checks to build system
make check ... clang-check (to avoid confusion).
> Start libclang based analyzer and TEST() check
> configure.ac | 2 +
> include/mk/config.mk.in | 5 +
> include/mk/env_post.mk | 8 ++
> include/mk/generic_leaf_target.inc | 5 +-
> include/mk/lib.mk | 3 +
> include/mk/rules.mk | 9 ++
> include/mk/testcases.mk | 1 +
> tools/clang-checks/.gitignore | 1 +
> tools/clang-checks/Makefile | 13 ++
> tools/clang-checks/main.c | 218 +++++++++++++++++++++++++++++
I'd name it tools/clang-check/ (and include/mk/clang-check.mk), but that's just
personal opinion.
Kind regards,
Petr
> 10 files changed, 264 insertions(+), 1 deletion(-)
> create mode 100644 tools/clang-checks/.gitignore
> create mode 100644 tools/clang-checks/Makefile
> create mode 100644 tools/clang-checks/main.c
next prev parent reply other threads:[~2021-06-04 6:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 15:48 [LTP] [RFC PATCH 0/2] Libclang based analyzer Richard Palethorpe
2021-06-03 15:48 ` [LTP] [RFC PATCH 1/2] Add 'make checks' and clang-checks to build system Richard Palethorpe
2021-06-04 6:06 ` Petr Vorel
2021-06-04 6:12 ` Petr Vorel
2021-06-04 8:42 ` Richard Palethorpe
2021-06-04 8:55 ` Petr Vorel
2021-06-03 15:48 ` [LTP] [RFC PATCH 2/2] Start libclang based analyzer and TEST() check Richard Palethorpe
2021-06-04 6:20 ` Petr Vorel [this message]
2021-06-04 9:03 ` [LTP] [RFC PATCH 0/2] Libclang based analyzer Richard Palethorpe
2021-06-04 9:15 ` Petr Vorel
2021-06-04 11:34 ` Cyril Hrubis
2021-06-04 12:51 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLnGIJWPf2XsAdTt@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox