From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Fri, 4 Jun 2021 08:20:16 +0200 Subject: [LTP] [RFC PATCH 0/2] Libclang based analyzer In-Reply-To: <20210603154825.30165-1-rpalethorpe@suse.com> References: <20210603154825.30165-1-rpalethorpe@suse.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Richie, > Hello, > This implements a TEST() check and integrates the check into the build > system. > Compared to the Coccinelle version it's very ugly. However I think > this will allow us to get all the low hanging fruit without creating > major problems for test developers. > I guess it could be run during CI if we either fix all the existing > TEST() usages in the library or add an ignore list. I already have a > Coccinelle script to help with the former. +1. FYI yesterday I sent patch to add make check{,-c,shell}, but for running C/shell API tests: https://patchwork.ozlabs.org/project/ltp/list/?series=247103 Taking 2 latests commits + adding clang-devel / libclang-dev packages makes CI running. https://github.com/pevik/ltp/commit/b2427f39ddb15c97761208a605637e0da6fe66ca The only missing piece is include/mk/clang-checks.mk (this patchset not even compile now). > Richard Palethorpe (2): > Add 'make checks' and clang-checks to build system make check ... clang-check (to avoid confusion). > Start libclang based analyzer and TEST() check > configure.ac | 2 + > include/mk/config.mk.in | 5 + > include/mk/env_post.mk | 8 ++ > include/mk/generic_leaf_target.inc | 5 +- > include/mk/lib.mk | 3 + > include/mk/rules.mk | 9 ++ > include/mk/testcases.mk | 1 + > tools/clang-checks/.gitignore | 1 + > tools/clang-checks/Makefile | 13 ++ > tools/clang-checks/main.c | 218 +++++++++++++++++++++++++++++ I'd name it tools/clang-check/ (and include/mk/clang-check.mk), but that's just personal opinion. Kind regards, Petr > 10 files changed, 264 insertions(+), 1 deletion(-) > create mode 100644 tools/clang-checks/.gitignore > create mode 100644 tools/clang-checks/Makefile > create mode 100644 tools/clang-checks/main.c