From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <pvorel@suse.cz>
Date: Fri, 4 Jun 2021 19:00:40 +0200
Subject: [LTP] [PATCH v2] doc: Modernize test-writing-guidelines
In-Reply-To: <20210603114208.8152-1-chrubis@suse.cz>
References: <20210603114208.8152-1-chrubis@suse.cz>
Message-ID: <YLpcOFM7Us0s+y87@pevik>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi Cyril,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

LGTM.

> -1.2 Code duplication
> -~~~~~~~~~~~~~~~~~~~~
> +* Do not write Makefiles from scratch, use LTP build system instead
> +
> +* Etc.
> +
> +
nit: sometimes you use 2 blank lines at the end of the chapter, sometimes just one.
> +1.2 Keep functions and variable names short
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Kind regards,
Petr