From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] futex_wake04: avoid tst_ts_from_ns overflow on 32-bit platforms
Date: Wed, 9 Jun 2021 10:23:06 +0200 [thread overview]
Message-ID: <YMB6aoVvTKJQ6wif@yuki> (raw)
In-Reply-To: <20210608132723.255996-1-cascardo@canonical.com>
Hi!
Good catch, I guess that it would be slightly cleaner to fix the
NSEC_PER_SEC size instead with:
diff --git a/include/lapi/common_timers.h b/include/lapi/common_timers.h
index b783beff4..e50f698d6 100644
--- a/include/lapi/common_timers.h
+++ b/include/lapi/common_timers.h
@@ -12,7 +12,7 @@
#include "lapi/posix_clocks.h"
#ifndef NSEC_PER_SEC
-#define NSEC_PER_SEC (1000000000L)
+#define NSEC_PER_SEC (1000000000LL)
#endif
static const clock_t clock_list[] = {
What do you think?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-06-09 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 13:27 [LTP] [PATCH] futex_wake04: avoid tst_ts_from_ns overflow on 32-bit platforms Thadeu Lima de Souza Cascardo
2021-06-09 8:23 ` Cyril Hrubis [this message]
2021-06-09 11:20 ` Thadeu Lima de Souza Cascardo
2021-06-09 13:38 ` Cyril Hrubis
2021-06-09 14:22 ` Thadeu Lima de Souza Cascardo
2021-06-09 14:09 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMB6aoVvTKJQ6wif@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox