public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4 v2] syscalls/io_submit: Add io_submit03 test for native AIO
Date: Thu, 10 Jun 2021 10:26:29 +0200	[thread overview]
Message-ID: <YMHMtS527P2OIHjs@yuki> (raw)
In-Reply-To: <20210608135718.36579-5-xieziyao@huawei.com>

Hi!
> +static void cleanup(void)
> +{
> +	if (rdonly_fd > 0)
> +		SAFE_CLOSE(rdonly_fd);
> +	if (wronly_fd > 0)
> +		SAFE_CLOSE(wronly_fd);
> +	TST_EXP_PASS_SILENT(tst_syscall(__NR_io_destroy, ctx));

I've replaced these PASS_SILENT() with plain old tst_brk(TBROK ...) in
the last two tests and pushed, thanks.


The TST_EXP_* macros are intended for the actual test and not for
setup/cleanup where the test is supposed to report TBROK if something
goes wrong.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2021-06-10  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 13:57 [LTP] [PATCH 0/4 v2] syscalls/aio: Add testcases for native AIO Xie Ziyao
2021-06-08 13:57 ` [LTP] [PATCH 1/4 v2] syscalls/io_destroy: Add io_destroy02 test " Xie Ziyao
2021-06-08 13:57 ` [LTP] [PATCH 2/4 v2] syscalls/io_setup: Add io_setup02 " Xie Ziyao
2021-06-08 13:57 ` [LTP] [PATCH 3/4 v2] syscalls/io_submit: Add io_submit02 " Xie Ziyao
2021-06-08 13:57 ` [LTP] [PATCH 4/4 v2] syscalls/io_submit: Add io_submit03 " Xie Ziyao
2021-06-10  8:26   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMHMtS527P2OIHjs@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox