From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] newlib_tests: Fix build dependency on lib
Date: Thu, 10 Jun 2021 15:03:33 +0200 [thread overview]
Message-ID: <YMINpZkS4j3bhN9O@yuki> (raw)
In-Reply-To: <20210610125229.24140-1-pvorel@suse.cz>
Hi!
> this fixes build error:
>
> $ cd lib && make clean && cd newlib_tests && make
> ld: cannot find -lltp
>
> Fixes: bbdb9f783 ("lib: Add new test library API")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> lib/newlib_tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/newlib_tests/Makefile b/lib/newlib_tests/Makefile
> index 30ca6810c..a263d7db5 100644
> --- a/lib/newlib_tests/Makefile
> +++ b/lib/newlib_tests/Makefile
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-or-later
> top_srcdir ?= ../..
>
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
Ah right, this adds dependency on the library and builds it if needed.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Btw the lib/tests/ subdirectory has the same problem, but I'm not sure
if we care enough to fix that...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-06-10 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:52 [LTP] [PATCH 1/1] newlib_tests: Fix build dependency on lib Petr Vorel
2021-06-10 13:03 ` Cyril Hrubis [this message]
2021-06-10 14:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMINpZkS4j3bhN9O@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox