public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] ssh-stress: Convert to new api
Date: Wed, 16 Jun 2021 16:36:45 +0200	[thread overview]
Message-ID: <YMoMfS+cFx4aau01@pevik> (raw)
In-Reply-To: <fb4b9d45-2cbb-5e5c-fefe-3ca429373a54@bell-sw.com>

Hi Joerg, Alexey,

...
> >  cleanup()
> >  {
> > +	local pids
> > +
> >  	# Stop the ssh daemon
> > -	test -s sshd.pid && kill $(cat sshd.pid)
> > -	pkill 'netstress$'
> > -	tst_rmdir
> > -	[ "$rtmpdir" ] && tst_rhost_run -c "rm -rf $rtmpdir"
> > -	TMPDIR=
> > +	[ -s sshd.pid ] && kill $(cat sshd.pid)
> > +	[ -n "$NETSTRESS_PID" ] && kill -2 $NETSTRESS_PID >/dev/null 2>&1
> > +
> > +	tst_rhost_run -c "kill $RHOST_PIDS"  >/dev/null 2>&1
And check also $RHOST_PIDS, right?
[ -n "$RHOST_PIDS" ] && tst_rhost_run -c "kill $RHOST_PIDS" >/dev/null 2>&1

> > +
> > +	# Kill all remaining ssh processes
> > +	tst_rhost_run -c "pkill -f '^ssh $RHOST_SSH_CONF'"

> Perhaps we should check that $RHOST_SSH_CONF is set before running
> pkill.
[ -n "$RHOST_SSH_CONF" ] && tst_rhost_run -c "pkill -f '^ssh $RHOST_SSH_CONF'"

No need to repost, I'll fix it before merge.

> For the rest:
> Reviewed-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Thanks!

Kind regards,
Petr

  reply	other threads:[~2021-06-16 14:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  8:18 [LTP] [PATCH v3] ssh-stress: Convert to new api Joerg Vehlow
2021-06-16 11:16 ` Petr Vorel
2021-06-16 14:11 ` Alexey Kodanev
2021-06-16 14:36   ` Petr Vorel [this message]
2021-06-17  4:20     ` Joerg Vehlow
2021-06-17  5:14       ` Petr Vorel
2021-06-17  5:18 ` Petr Vorel
2021-06-17  6:56   ` Joerg Vehlow
2021-06-17 12:41     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMoMfS+cFx4aau01@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox