[LTP] [PATCH 2/3] syscalls/sendfile: Convert sendfile06 to the new API

Xie Ziyao
2021-06-18T03:37:57Z

Hi, Petr,

>
>> 1. Convert sendfile06 to the new API with file descriptors instead
>> of socket descriptors.
> I wonder if this is ok, suppose yes, but better if other check.
I noticed that it is described in `man 2 sendfile` as follows:

In Linux kernels before 2.6.33, out_fd must refer to a socket. Since
Linux 2.6.33 it can be any file.

And if we need to cover the case where out_fd is a socket, I suggest
adding it to sendfile02.c, which tests the basic functionality of the
sendfile(), just like sendfile07.c:

in_fd = SAFE_OPEN("in_file", O_RDONLY);

SAFE_SOCKETPAIR(PF_UNIX, SOCK_DGRAM | SOCK_NONBLOCK, 0, p);
out_fd = p[1];

>
>> 2. Remove the support for UCLINUX.
>
> LGTM.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> ...
>> + TEST(sendfile(out_fd, in_fd, NULL, sb.st_size));
>> + after_pos = SAFE_LSEEK(in_fd, 0, SEEK_CUR);
>> +
>> + if (TST_RET != sb.st_size)
> nit: checkpatch.pl complains, it should be if (sb.st_size != TST_RET)
> (can be fixed during merge)
Oh yes, sometimes forgot to use checkpatch.pl to check my code files.
Thanks for your tips, Petr.

Kind Regards,
Ziyao