From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] syscalls/sendfile: Convert sendfile06 to the new API
Date: Thu, 17 Jun 2021 22:06:29 +0200 [thread overview]
Message-ID: <YMurRVXwyvKXnkjj@pevik> (raw)
In-Reply-To: <20210603033611.15619-3-xieziyao@huawei.com>
Hi Ziyao,
> 1. Convert sendfile06 to the new API with file descriptors instead
> of socket descriptors.
I wonder if this is ok, suppose yes, but better if other check.
> 2. Remove the support for UCLINUX.
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> + TEST(sendfile(out_fd, in_fd, NULL, sb.st_size));
> + after_pos = SAFE_LSEEK(in_fd, 0, SEEK_CUR);
> +
> + if (TST_RET != sb.st_size)
nit: checkpatch.pl complains, it should be if (sb.st_size != TST_RET)
(can be fixed during merge)
Kind regards,
Petr
next prev parent reply other threads:[~2021-06-17 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 3:36 [LTP] [PATCH 0/3] Fix and convert sendfile{02, 06} to the new API Xie Ziyao
2021-06-03 3:36 ` [LTP] [PATCH 1/3] syscalls/sendfile: Convert sendfile02 " Xie Ziyao
2021-06-16 14:15 ` Petr Vorel
2021-06-03 3:36 ` [LTP] [PATCH 2/3] syscalls/sendfile: Convert sendfile06 " Xie Ziyao
2021-06-17 20:06 ` Petr Vorel [this message]
2021-06-18 3:37 ` Xie Ziyao
2021-06-18 8:14 ` Petr Vorel
2021-06-18 8:03 ` Cyril Hrubis
2021-06-21 12:12 ` Petr Vorel
2021-06-03 3:36 ` [LTP] [PATCH 3/3] syscalls/sendfile: Remove unnecessary header files Xie Ziyao
2021-06-17 20:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMurRVXwyvKXnkjj@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox