From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib: limit the size of tmpfs in LTP
Date: Fri, 2 Jul 2021 13:40:59 +0200 [thread overview]
Message-ID: <YN77SxjQ2tHeXJfp@yuki> (raw)
In-Reply-To: <CAEemH2dJ4FYh-7-8C5na-uB1jg31mdV8wC+7w_DHG1463XudHA@mail.gmail.com>
Hi!
> > > +
> > > + if (!strcmp(tdev.fs_type, "tmpfs"))
> > > + tst_test->mnt_data = mnt_data;
> >
> > I guess that we are doing this in order to export the changes in the
> > mnt_data to the test, right?
> >
> > Is that needed for something or are you doing this just in a case that
> > somebody will use that?
> >
>
> No, you probably mis-read this part.
>
> In contrast, this is just to restore it to the original value,
> because we don't want to export the changed tst_test->mnt_data
> take effect on other filesystems.
I'm just asking why we are setting it in the first place?
If we do not change it there is no need to restore the value, so the
real question is, do we need to change the tst_test->mnt_data at all?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-02 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 5:52 [LTP] [PATCH 1/2] lib: limit the size of tmpfs in LTP Li Wang
2021-07-01 5:52 ` [LTP] [PATCH 2/2] lib: mount tmpfs name as ltp-tmpfs Li Wang
2021-07-02 9:23 ` Cyril Hrubis
2021-07-02 9:21 ` [LTP] [PATCH 1/2] lib: limit the size of tmpfs in LTP Cyril Hrubis
2021-07-02 12:01 ` Li Wang
2021-07-02 11:40 ` Cyril Hrubis [this message]
2021-07-02 12:20 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN77SxjQ2tHeXJfp@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox