public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 1/1] make: Add make test{, -c, -c-run, -shell-run} targets
Date: Tue, 22 Jun 2021 12:10:38 +0200	[thread overview]
Message-ID: <YNG3HmqqBGNfWLOI@pevik> (raw)
In-Reply-To: <YNGybhjq161LwfaN@pevik>

Hi all,

...
> > Why not just add runtest.sh into newlib_tests/ that would do all the
> > work, then we can forget about all the trickery and just run the scritp
> > on 'make test-c'. Well we would have to call make in newlib_tests first
> > to make sure it was compiled, but that should be it.

> > And the same for testcases/lib/.

> > I do not think that adding a target per a testcase is sane.

> Thanks for your input, makes sense. Actually, adding a script which would run it
> was my approach in 2 years old patch [1].

> I'll add runtest.sh which will run all tests which by default TPASS/TCONF now,
> but possible to specify just some tests (speedup the development).

Also make install works also on lib/newlib_tests. Thus I'll install also runtest.sh
and try to setup PATH a way it works on both running from git and running from
make install. It might be worth to have lib tests runnable on SUT.

Kind regards,
Petr

> After we merge it I'll continue in Christian's effort to add metadata of
> expected output [2], which allows us to run all tests (including these which
> fail).

> I suggest to add 3 targets: make test test-c test-shell (test will run both
> test-c test-shell).

> Kind regards,
> Petr

> [1] https://patchwork.ozlabs.org/project/ltp/patch/20190924182841.4528-1-pvorel@suse.cz/
> [2] https://patchwork.ozlabs.org/project/ltp/patch/ce675759672af52bea02c11d51bd7d10f0bcb5cb.1566500817.git.clanig@suse.com/

      reply	other threads:[~2021-06-22 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 19:12 [LTP] [RFC PATCH v2 1/1] make: Add make test{, -c, -c-run, -shell-run} targets Petr Vorel
2021-06-21  8:41 ` Richard Palethorpe
2021-06-21  8:48   ` Petr Vorel
2021-06-22  8:59 ` Cyril Hrubis
2021-06-22  9:50   ` Petr Vorel
2021-06-22 10:10     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNG3HmqqBGNfWLOI@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox