public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/8] Fix uninitialized var errors
Date: Tue, 22 Jun 2021 15:54:29 +0200	[thread overview]
Message-ID: <YNHrldS4vrr2BN/t@yuki> (raw)
In-Reply-To: <20210622113514.22284-1-rpalethorpe@suse.com>

Hi!
> In a lot of cases the compiler is simply confused and gives an error,
> but there is no undefined behaviour. This is often caused by tst_brk
> which is the source of much confusion. Most likely there should be two
> versions of tst_brk. One which never returns and is used by test
> authors and one which can return, but is usually only used in library
> functions which may be called from cleanup.

Having two tst_brk() wouldn't solve much since all SAFE_MACROS() still
needs to use the one that may return.

So as far as I can tell it's easier to initialize variables to 0 in the
few cases where compiler ends up confused.

Anyways whole patchset pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2021-06-22 13:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 11:35 [LTP] [PATCH 0/8] Fix uninitialized var errors Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 1/8] ipc: Fix uninitialized var error by removing useless arg Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 2/8] ftest: Fix uninitialized var error Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 3/8] hotplug: Fix uninitialized var Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 4/8] dio: Fix uninitialized var error Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 5/8] ksmg01: " Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 6/8] shmat01: " Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 7/8] crash02: Save actual child PID instead of uninitialized variable Richard Palethorpe
2021-06-22 11:35 ` [LTP] [PATCH 8/8] locktests: Fix uninitialized var error Richard Palethorpe
2021-06-22 13:54 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNHrldS4vrr2BN/t@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox