From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] device-drivers/cpufreq_boost: skip test on virtual machines
Date: Wed, 23 Jun 2021 13:38:30 +0200 [thread overview]
Message-ID: <YNMdNqGiGXOgby6v@yuki> (raw)
In-Reply-To: <2a08d5c4-c002-7284-03d1-ff4441f8c9c5@canonical.com>
Hi!
> > diff --git a/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c b/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c
> > index b9739db37cb7..67917b3fea25 100644
> > --- a/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c
> > +++ b/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c
> > @@ -90,6 +90,9 @@ static void setup(void)
> > unsigned int i;
> > tst_require_root();
> >
> > + if (tst_is_virt(VIRT_ANY))
> > + tst_brkm(TCONF, NULL, "running in a virtual machine, overclock not reliably measureable");
> > +
> > for (i = 0; i < ARRAY_SIZE(cdrv); ++i) {
> > fd = open(cdrv[i].file, O_RDWR);
> > if (fd == -1)
> >
>
> Optionally, under virtual machine the test failure could be converted to
> accepted pass. This would still allow to test CPUfreq boosting
> interface. Any preferences?
I wonder what is the likehood of actually dicovering a bug by writing to
the cpufreq boost file from within a VM, I guess that it's non-zero at
least.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-06-23 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 8:01 [LTP] [PATCH] device-drivers/cpufreq_boost: skip test on virtual machines Krzysztof Kozlowski
2021-06-23 8:11 ` Krzysztof Kozlowski
2021-06-23 11:38 ` Cyril Hrubis [this message]
2021-06-23 15:33 ` Krzysztof Kozlowski
2021-08-11 10:12 ` Krzysztof Kozlowski
2021-09-08 13:03 ` Cyril Hrubis
2021-09-08 13:03 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNMdNqGiGXOgby6v@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox