From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/4] include/tst_pid.h: fix language typo (subtraction)
Date: Mon, 28 Jun 2021 21:29:16 +0200 [thread overview]
Message-ID: <YNojDI7jzK0P0QRS@pevik> (raw)
In-Reply-To: <c02beb1f-31f8-8902-8be8-27b4bf9ecfe2@canonical.com>
> On 28/06/2021 16:49, Petr Vorel wrote:
> > Hi Krzysztof,
> >> /*
> >> - * Returns number of free pids by substarction of the number of pids
> >> + * Returns number of free pids by subtraction of the number of pids
> >> * currently used ('ps -eT') from max_pids
> > Because you change the description of this function in the next commit,
> > I'd just fix this simple typo in 2nd commit. But of course it's not wrong
> > (prevents keeping the fix even if we'd removed second commit).
> The commits should do only one thing (fix one bug, bring one feature if
> possible) and the next commit does not touch that line. There is no
> re-doing of the same change in next commit.
As I wrote in this case I wouldn't bother (with test rewrite to new API there
are much more changes in single commit), but sure you're right this is the best
practice which we follow.
Kind regards,
Petr
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2021-06-28 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 13:59 [LTP] [PATCH v3 0/4] syscalls/msgstress: fixes for small systems Krzysztof Kozlowski
2021-06-23 13:59 ` [LTP] [PATCH v3 1/4] include/tst_pid.h: fix language typo (subtraction) Krzysztof Kozlowski
2021-06-28 14:49 ` Petr Vorel
2021-06-28 15:50 ` Krzysztof Kozlowski
2021-06-28 19:29 ` Petr Vorel [this message]
2021-06-23 13:59 ` [LTP] [PATCH v3 2/4] syscalls/msgstress04: fix fork failure on small memory systems Krzysztof Kozlowski
2021-06-28 14:47 ` Petr Vorel
2021-06-28 16:05 ` Krzysztof Kozlowski
2021-06-23 13:59 ` [LTP] [PATCH v3 3/4] syscalls/msgstress03: " Krzysztof Kozlowski
2021-06-23 13:59 ` [LTP] [PATCH v3 4/4] syscalls/msgstress: tune limit of processes for small machines Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNojDI7jzK0P0QRS@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox