From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ltp_tpci.c: Add release operation before allocation
Date: Mon, 28 Jun 2021 22:29:30 +0200 [thread overview]
Message-ID: <YNoxKg+Hm0qa3Z70@pevik> (raw)
In-Reply-To: <20210401125127.45600-1-wangxin410@huawei.com>
Hi Xin,
> When we run the test case, the following results will be obtained:
> test_pci 283 TPASS : PCI bus 7d slot 00 : Test-case '11'
> test_pci 284 TFAIL : tpci.c:74: PCI bus 7d slot 00 : Test-case '12'
> ...
> test_pci 300 TFAIL : tpci.c:74: PCI bus 7d slot 01 : Test-case '12'
> test_pci 301 TPASS : PCI bus 7d slot 01 : Test-case '13'
> The analysis is that the space allocated by the bios is insufficient.
> The solution to this problem can be in add pci_release_resource(dev, i)
> before system resources are reallocated.Because the resources have been
> allocated when the system is initialized.If it is redistributed, it
> should be released and then allocated.
I wonder if this is the same issue as the one described by Krzysztof in his
patch:
https://patchwork.ozlabs.org/project/ltp/patch/20210401125127.45600-1-wangxin410@huawei.com/
Could you please share what HW and kernel you use and post dmesg?
Kind regards,
Petr
> Signed-off-by: Wang Xin <wangxin410@huawei.com>
> ---
> testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
> index e29821dda..5b0896093 100644
> --- a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
> +++ b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
> @@ -439,6 +439,7 @@ static int test_assign_resources(void)
> if (r->flags & IORESOURCE_MEM &&
> r->flags & IORESOURCE_PREFETCH) {
> + pci_release_resource(dev, i);
> ret = pci_assign_resource(dev, i);
> prk_info("assign resource to '%d', ret '%d'", i, ret);
> rc |= (ret < 0 && ret != -EBUSY) ? TFAIL : TPASS;
> 2.17.1
next prev parent reply other threads:[~2021-06-28 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:51 [LTP] [PATCH] ltp_tpci.c: Add release operation before allocation Wang Xin
2021-06-28 20:29 ` Petr Vorel [this message]
2021-06-29 9:38 ` Krzysztof Kozlowski
2021-07-07 7:04 ` Krzysztof Kozlowski
2021-07-07 7:21 ` Krzysztof Kozlowski
2021-07-26 8:36 ` Petr Vorel
2021-07-26 8:40 ` Petr Vorel
2021-07-26 8:44 ` Krzysztof Kozlowski
2021-07-26 8:55 ` Petr Vorel
2021-06-30 2:14 ` [LTP] 答复: " wangxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNoxKg+Hm0qa3Z70@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox