From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Failing test on failing shell commands
Date: Tue, 13 Jul 2021 14:35:40 +0200 [thread overview]
Message-ID: <YO2InGIKtRJOZPOy@yuki> (raw)
In-Reply-To: <c253160b-7326-8583-9713-8b3978473c7d@canonical.com>
Hi!
> > We do have ROD (as a shorthand for "run or die") in the shell test
> > library, so this really should be:
> >
> > ROD mkdir subgroup
>
> Thanks. This will however fail entire suite (memcg_use_hierarchy_test)
> and other tests won't get executed. The failure could be only local, so
> other tests are still meaningful.
If you want to exit the subtest you really have to handle the return
values yourself, report the error, and return from the test function.
The question is which status to report. The TBROK status means that test
has failed setup phase and there is no point to continue, so this
probably should map to tst_res TWARN "...".
Another solution would be splitting the test into three seprate tests
so that we can use ROD.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-13 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:56 [LTP] Failing test on failing shell commands Krzysztof Kozlowski
2021-07-13 11:55 ` Cyril Hrubis
2021-07-13 12:32 ` Krzysztof Kozlowski
2021-07-13 12:35 ` Cyril Hrubis [this message]
2021-07-13 12:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO2InGIKtRJOZPOy@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox