From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] gethostid: skip test if sethostid undefined
Date: Thu, 8 Jul 2021 14:58:29 +0200 [thread overview]
Message-ID: <YOb2ddFMEW1aniyI@yuki> (raw)
In-Reply-To: <20210708130602.970689-1-liwang@redhat.com>
Hi!
> This is to avoid compiling error if the sethostid() is not
> implemented, e.g. build with Alpine's musl-libc.
>
> CI: https://github.com/wangli5665/ltp/runs/3019192920
>
> Signed-off-by: Li Wang <liwang@redhat.com>
> ---
> configure.ac | 1 +
> testcases/kernel/syscalls/gethostid/gethostid01.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 1a43ebea8..25c421de0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -128,6 +128,7 @@ AC_CHECK_FUNCS_ONCE([ \
> renameat2 \
> sched_getcpu \
> sendmmsg \
> + sethostid \
> setns \
> sigpending \
> splice \
> diff --git a/testcases/kernel/syscalls/gethostid/gethostid01.c b/testcases/kernel/syscalls/gethostid/gethostid01.c
> index 802604777..20e4cd307 100644
> --- a/testcases/kernel/syscalls/gethostid/gethostid01.c
> +++ b/testcases/kernel/syscalls/gethostid/gethostid01.c
> @@ -26,6 +26,8 @@
>
> #include "tst_test.h"
Shouldn't we include config.h here?
> +#ifdef HAVE_SETHOSTID
> +
> static long origin;
> static long tc[] = {0x00000000, 0x0000ffff};
>
> @@ -64,3 +66,7 @@ static struct tst_test test = {
> .needs_root = 1,
> .tcnt = ARRAY_SIZE(tc),
> };
> +
> +#else
> +TST_TEST_TCONF("sethostid is undefined.");
> +#endif
Other than that Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-08 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 13:06 [LTP] [PATCH] gethostid: skip test if sethostid undefined Li Wang
2021-07-08 12:58 ` Cyril Hrubis [this message]
2021-07-08 13:35 ` Li Wang
2021-07-08 17:00 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOb2ddFMEW1aniyI@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox