From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/7] meltdown: Set CFLAGS for check targets
Date: Thu, 8 Jul 2021 15:11:31 +0200 [thread overview]
Message-ID: <YOb5g66KfDWx77Hr@yuki> (raw)
In-Reply-To: <20210629072710.23800-4-rpalethorpe@suse.com>
Hi!
> The include set in the CFLAGS is necessary for Sparse to parse the
> test source. If a specific target has variables set on it. Then these
> won't be available to the corresponding check-target. Usually this is
> not a problem because most variables set on a target are just for
> linking and the checker doesn't need them.
>
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
> testcases/cve/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/cve/Makefile b/testcases/cve/Makefile
> index ddf8b6fe1..7b011b6c9 100644
> --- a/testcases/cve/Makefile
> +++ b/testcases/cve/Makefile
> @@ -19,6 +19,7 @@ cve-2014-0196: LDLIBS += -lutil
> endif
>
> meltdown: CFLAGS += -I$(abs_srcdir)/../realtime/include
> +check-meltdown: CFLAGS += -I$(abs_srcdir)/../realtime/include
Uff, this will likely bite us in a different ways later on.
I guess that it would be cleaner to move the libtsc.h into top level
include so that it's clear that the header is used in several tests.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-08 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 7:27 [LTP] [PATCH 0/7] Sparse based checker and rule proposal Richard Palethorpe
2021-06-29 7:27 ` [LTP] [PATCH 1/7] Add Sparse based checker and TST_RET/ERR check Richard Palethorpe
2021-07-08 13:19 ` Cyril Hrubis
2021-07-09 7:47 ` Richard Palethorpe
2021-06-29 7:27 ` [LTP] [PATCH 2/7] Add 'make check' to the build system Richard Palethorpe
2021-06-29 7:27 ` [LTP] [PATCH 3/7] meltdown: Set CFLAGS for check targets Richard Palethorpe
2021-07-08 13:11 ` Cyril Hrubis [this message]
2021-07-09 7:49 ` Richard Palethorpe
2021-06-29 7:27 ` [LTP] [PATCH 4/7] doc: Add rules and recommendations list Richard Palethorpe
2021-07-08 13:34 ` Cyril Hrubis
2021-06-29 7:27 ` [LTP] [PATCH 5/7] doc: Remind authors and maintainers to run make check Richard Palethorpe
2021-07-08 13:35 ` Cyril Hrubis
2021-06-29 7:27 ` [LTP] [PATCH 6/7] doc: Document TEST macro and state TST_RET/ERR rule LTP-002 Richard Palethorpe
2021-07-01 7:17 ` Richard Palethorpe
2021-06-29 7:27 ` [LTP] [PATCH 7/7] Reference LTP-002 rule in Cocci scripts Richard Palethorpe
2021-07-08 13:38 ` [LTP] [PATCH 0/7] Sparse based checker and rule proposal Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOb5g66KfDWx77Hr@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox