public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] lib/tst_test.sh: skip test if ip returns "Error: Unknown device type"
Date: Tue, 27 Jul 2021 12:02:46 +0200	[thread overview]
Message-ID: <YP/ZxhYSZb/NusUs@pevik> (raw)
In-Reply-To: <8cc8d5bc-b651-8e15-6389-69f36cf6bb49@bell-sw.com>

Hi Alexey, Radoslav,

> Hi Radoslav,

> On 27.07.2021 11:20, Radoslav Kolev wrote:
> > On 7/22/21 10:49 AM, Petr Vorel wrote:
> >> Hi Radoslav,

> >>> In network stress test groups there are tests expecting
> >>> CONFIG_NET_IPVTI to be enabled in the kernel, and if it's not they
> >>> fail. There is a check for VTI support in the ip utility, but not
> >>> for the kernel. Skip these tests if vti device type is not known by
> >>> the kernel.
> >> LGTM.
> >> Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > Thanks for the review, Petr!

> > Alexey, please let me know if you have any comments.



> What about checking vti drivers in stress/ipsec/ipsec_lib.sh:tst_ipsec_setup_vti()
> Similar to the checks for xfrm_user driver there...

> For example:

> tst_net_run -q "tst_check_drivers ip_vti ip6_vti" || \
>     tst_brk TCONF "vti driver not available on lhost or rhost"


> I think this should work for wireguard02 test as well.

The above LGTM, Radoslav, do you have time to look into it?
Alexey, do we also accept this patch? IMHO this error should be mostly TCONF and
it'd work for other possible drivers.

Kind regards,
Petr

  reply	other threads:[~2021-07-27 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  6:34 [LTP] [PATCH v1] lib/tst_test.sh: skip test if ip returns "Error: Unknown device type" Radoslav Kolev
2021-07-22  7:49 ` Petr Vorel
2021-07-27  8:20   ` Radoslav Kolev
2021-07-27  8:44     ` Alexey Kodanev
2021-07-27 10:02       ` Petr Vorel [this message]
2021-07-28 11:38         ` Alexey Kodanev
2021-07-28 13:06           ` Petr Vorel
2021-07-28 14:00             ` Radoslav Kolev
2021-07-28 14:04             ` [LTP] [PATCH v2] ipsec_lib.sh: check ip_vti/ip6_vti are enabled or skip tests Radoslav Kolev
2021-07-30  7:08               ` Petr Vorel
2021-07-30  7:50                 ` Alexey Kodanev
2021-07-30  9:45                   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP/ZxhYSZb/NusUs@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox