From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3, 1/2] lib/tst_test.sh: Make tst_umount work with argument that has trailing slash
Date: Mon, 19 Jul 2021 08:49:08 +0200 [thread overview]
Message-ID: <YPUgZGgztmG04Mfa@pevik> (raw)
In-Reply-To: <20210716140142.GA7113@andestech.com>
Hi,
...
> while [ "$i" -lt 50 ]; do
> - if umount "$device" > /dev/null; then
> + if umount "$device"/ > /dev/null; then
nit: although previous is working, I'd prefer "$device/"
Kind regards,
Petr
prev parent reply other threads:[~2021-07-19 6:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 14:01 [LTP] [PATCH v3, 1/2] lib/tst_test.sh: Make tst_umount work with argument that has trailing slash Leo Liang
2021-07-19 5:19 ` xuyang2018.jy
2021-07-19 5:51 ` Petr Vorel
2021-07-19 5:58 ` Petr Vorel
2021-07-19 6:20 ` xuyang2018.jy
2021-07-19 6:45 ` Petr Vorel
2021-07-19 8:18 ` Leo Liang
2021-07-19 6:49 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPUgZGgztmG04Mfa@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox