From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 00/16] syscalls/sched_*: convert to new API and handle ENOSYS errno
Date: Tue, 20 Jul 2021 16:06:52 +0200 [thread overview]
Message-ID: <YPbYfPWly+3kW7y5@yuki> (raw)
In-Reply-To: <f9767568-466f-73d2-7d73-aa880fde6a63@bell-sw.com>
Hi!
> >> The patch-set introduced new tst_sched_* wrappers to handle ENOSYS
> >> error that can be returned by libc (musl [1]). In that particular
> >> case the wrapper uses syscall directly to test the kernel anyway.
> >
> > Can't we use the test_variants to test both the kernel and libc calls
> > instead?
>
> With glibc it seems it would be just a redundant work to call both
> variants, wouldn't it?
I do not think so, since the libc wrappers may be more complex than just
a syscall(__NR_foo, ...). At least recently the libc variants are
switching between foo and foo_time64 syscall variants and convert the
timespecs accordingly.
> BTW, sched_rr_get_interval* tests already using tst_variants, adding
> more variants will double them too, right?
That's true and this makes things slightly more complicated. But as
these test just calls a few syscalls and check return values I doubt
that doubling the test matrix would be measureable in the test runtime.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-07-20 14:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:33 [LTP] [PATCH 00/16] syscalls/sched_*: convert to new API and handle ENOSYS errno Alexey Kodanev
2021-07-20 13:18 ` Cyril Hrubis
2021-07-20 14:06 ` Alexey Kodanev
2021-07-20 14:06 ` Cyril Hrubis [this message]
2021-07-20 14:23 ` Cyril Hrubis
2021-07-20 15:26 ` Alexey Kodanev
2021-07-20 17:23 ` Cyril Hrubis
2021-07-20 13:33 ` [LTP] [PATCH 01/16] lib/tst_sched: add ltp tst_sched_*() Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 02/16] syscalls/sched_getparam01: use tst_sched_*() Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 03/16] syscalls/sched_getparam03: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 04/16] syscalls/sched_setparam01: convert to new API Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 05/16] syscalls/sched_setparam02: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 06/16] syscalls/sched_setparam03: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 07/16] syscalls/sched_setparam04: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 08/16] syscalls/sched_setparam05: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 09/16] syscalls/sched_rr_get_interval01: use tst_sched_*() Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 10/16] syscalls/sched_rr_get_interval02: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 11/16] syscalls/sched_rr_get_interval03: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 12/16] syscalls/sched_setscheduler01: convert to new API Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 13/16] syscalls/sched_setscheduler02: " Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 14/16] syscalls/sched_setscheduler03: use tst_sched_*() Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 15/16] syscalls/sched_getscheduler01: convert to new API Alexey Kodanev
2021-07-20 13:33 ` [LTP] [PATCH 16/16] syscalls/sched_getscheduler02: " Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbYfPWly+3kW7y5@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox