public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] lib/tst_test.sh: skip test if ip returns "Error: Unknown device type"
Date: Thu, 22 Jul 2021 09:49:39 +0200	[thread overview]
Message-ID: <YPkjE3KHHnhYklp/@pevik> (raw)
In-Reply-To: <20210722063422.18059-1-radoslav.kolev@suse.com>

Hi Radoslav,

> In network stress test groups there are tests expecting
> CONFIG_NET_IPVTI to be enabled in the kernel, and if it's not they
> fail. There is a check for VTI support in the ip utility, but not
> for the kernel. Skip these tests if vti device type is not known by
> the kernel.

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> Signed-off-by: Radoslav Kolev <radoslav.kolev@suse.com>
> ---
>  testcases/lib/tst_test.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> index c6aa2c487..0458c90c2 100644
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -241,12 +241,13 @@ TST_RTNL_CHK()
>  	local msg1="RTNETLINK answers: Function not implemented"
>  	local msg2="RTNETLINK answers: Operation not supported"
>  	local msg3="RTNETLINK answers: Protocol not supported"
> +	local msg4="Error: Unknown device type"
>  	local output="$($@ 2>&1 || echo 'LTP_ERR')"
>  	local msg

>  	echo "$output" | grep -q "LTP_ERR" || return 0

> -	for msg in "$msg1" "$msg2" "$msg3"; do
> +	for msg in "$msg1" "$msg2" "$msg3" "$msg4"; do
>  		echo "$output" | grep -q "$msg" && tst_brk TCONF "'$@': $msg"
>  	done

  reply	other threads:[~2021-07-22  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  6:34 [LTP] [PATCH v1] lib/tst_test.sh: skip test if ip returns "Error: Unknown device type" Radoslav Kolev
2021-07-22  7:49 ` Petr Vorel [this message]
2021-07-27  8:20   ` Radoslav Kolev
2021-07-27  8:44     ` Alexey Kodanev
2021-07-27 10:02       ` Petr Vorel
2021-07-28 11:38         ` Alexey Kodanev
2021-07-28 13:06           ` Petr Vorel
2021-07-28 14:00             ` Radoslav Kolev
2021-07-28 14:04             ` [LTP] [PATCH v2] ipsec_lib.sh: check ip_vti/ip6_vti are enabled or skip tests Radoslav Kolev
2021-07-30  7:08               ` Petr Vorel
2021-07-30  7:50                 ` Alexey Kodanev
2021-07-30  9:45                   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPkjE3KHHnhYklp/@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox