From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] msgget03: don't depend on existed shared resources
Date: Fri, 23 Jul 2021 14:24:15 +0200 [thread overview]
Message-ID: <YPq0749ZnnGsAV2q@pevik> (raw)
In-Reply-To: <60FA81E4.3060709@fujitsu.com>
Hi all,
> Hi Cyril, Petr
> > Hi!
> >>> I think that we allready discussed this in another thread:
> >>> https://lists.linux.it/pipermail/ltp/2021-July/023831.html
> >> Thanks, I forgot this. In that case my approach (not using<=, but count
> >> segments in /proc/sysvipc/shm before testing) might be more precise.
> >> But no strong feeling about that, both solutions fix the test, let's chose one
> >> and merge.
> > As I said previously, there are many SysV IPC tests that do expect that
> > nobody will add/remove IPC shm/queue/semaphores during the testrun and
> > some of the testcases cannot even be implemented without this
> > expectation.
> > Hence I wouldn't complicate the test here and just count how many
> > segments are there at the start and be done with it.
> Agree.
> A possible solution(alter get_used_queues api in new ipc lib and add
> file parametrers, so we can use this api for msgget03) I have mentioned
> in the previous email, the url as below:
> https://lists.linux.it/pipermail/ltp/2021-July/023653.html
LGTM. Or use /proc/sysvipc/shm instead of /proc/sysvipc/msg in get_used_queues()
as you noted get_used_queues() has not been used yet.
BTW searching where get_used_queues() appeared, I see [LTP] [PATCH v3 1/4]
syscalls/ipc: add newipc library for new API [1], but if I'm not mistaken
get_used_queues() was not used even there, maybe it was in some previous
versions.
Kind regards,
Petr
[1] https://lists.linux.it/pipermail/ltp/2016-December/003239.html
next prev parent reply other threads:[~2021-07-23 12:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 7:52 [LTP] [PATCH v2 1/2] shmget03: don't depend on existed shared resources Alexey Kodanev
2021-07-12 7:52 ` [LTP] [PATCH v2 2/2] msgget03: " Alexey Kodanev
2021-07-22 7:55 ` Petr Vorel
2021-07-22 12:14 ` Cyril Hrubis
2021-07-22 13:01 ` Petr Vorel
2021-07-22 13:02 ` Cyril Hrubis
2021-07-23 8:46 ` xuyang2018.jy
2021-07-23 12:24 ` Petr Vorel [this message]
2021-07-27 5:51 ` xuyang2018.jy
2021-08-04 1:45 ` xuyang2018.jy
2021-08-04 14:48 ` Cyril Hrubis
2021-08-04 15:45 ` Petr Vorel
2021-08-05 3:43 ` xuyang2018.jy
2021-08-05 6:36 ` Petr Vorel
2021-08-05 6:58 ` xuyang2018.jy
2021-07-23 12:11 ` Petr Vorel
2021-07-12 8:28 ` [LTP] [PATCH v2 1/2] shmget03: " Li Wang
2021-07-12 8:37 ` Alexey Kodanev
2021-07-12 8:42 ` Li Wang
2021-07-12 8:55 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPq0749ZnnGsAV2q@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox