From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] broken_ip: TCONF when test run on unsupported protocol
Date: Tue, 27 Jul 2021 19:35:31 +0200 [thread overview]
Message-ID: <YQBD4w2nKwY2G1l+@pevik> (raw)
In-Reply-To: <57d4c109-d01a-2c7f-39c7-41013e70abf9@bell-sw.com>
Hi Alexey,
> On 14.07.2021 17:07, Petr Vorel wrote:
> > net_stress.broken_ip runtest file is correct, but some users try to run
> > tests manually.
> > Fixes: #843
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > testcases/network/stress/broken_ip/broken_ip-checksum | 3 ++-
> > testcases/network/stress/broken_ip/broken_ip-fragment | 3 ++-
> > testcases/network/stress/broken_ip/broken_ip-ihl | 3 ++-
> > testcases/network/stress/broken_ip/broken_ip-nexthdr | 3 ++-
> > testcases/network/stress/broken_ip/broken_ip-protcol | 3 ++-
> > 5 files changed, 10 insertions(+), 5 deletions(-)
> > diff --git a/testcases/network/stress/broken_ip/broken_ip-checksum b/testcases/network/stress/broken_ip/broken_ip-checksum
> > index 78f00ce98..707ffcb29 100644
> > --- a/testcases/network/stress/broken_ip/broken_ip-checksum
> > +++ b/testcases/network/stress/broken_ip/broken_ip-checksum
> > @@ -1,11 +1,12 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-or-later
> > -# Copyright (c) 2019 Petr Vorel <pvorel@suse.cz>
> > +# Copyright (c) 2019-2021 Petr Vorel <pvorel@suse.cz>
> > # Copyright (c) 2014-2017 Oracle and/or its affiliates. All Rights Reserved.
> > # Copyright (c) International Business Machines Corp., 2006
> > # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> > TST_TESTFUNC="do_test"
> > +TST_NET_IPV4_ONLY=1
> > . tst_net.sh
> > do_test()
> > diff --git a/testcases/network/stress/broken_ip/broken_ip-fragment b/testcases/network/stress/broken_ip/broken_ip-fragment
> > index 1f5e5f713..7356bb523 100644
> > --- a/testcases/network/stress/broken_ip/broken_ip-fragment
> > +++ b/testcases/network/stress/broken_ip/broken_ip-fragment
> > @@ -1,11 +1,12 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-or-later
> > -# Copyright (c) 2019 Petr Vorel <pvorel@suse.cz>
> > +# Copyright (c) 2019-2021 Petr Vorel <pvorel@suse.cz>
> > # Copyright (c) 2014-2017 Oracle and/or its affiliates. All Rights Reserved.
> > # Copyright (c) International Business Machines Corp., 2006
> > # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> > TST_TESTFUNC="do_test"
> > +TST_NET_IPV4_ONLY=1
> > . tst_net.sh
> > do_test()
> > diff --git a/testcases/network/stress/broken_ip/broken_ip-ihl b/testcases/network/stress/broken_ip/broken_ip-ihl
> > index 9f2a42568..e5e41ee8e 100644
> > --- a/testcases/network/stress/broken_ip/broken_ip-ihl
> > +++ b/testcases/network/stress/broken_ip/broken_ip-ihl
> > @@ -1,11 +1,12 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-or-later
> > -# Copyright (c) 2019 Petr Vorel <pvorel@suse.cz>
> > +# Copyright (c) 2019-2021 Petr Vorel <pvorel@suse.cz>
> > # Copyright (c) 2014-2017 Oracle and/or its affiliates. All Rights Reserved.
> > # Copyright (c) International Business Machines Corp., 2006
> > # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> > TST_TESTFUNC="do_test"
> > +TST_NET_IPV4_ONLY=1
> > . tst_net.sh
> > do_test()
> > diff --git a/testcases/network/stress/broken_ip/broken_ip-nexthdr b/testcases/network/stress/broken_ip/broken_ip-nexthdr
> > index 475b92b16..2ab0601ac 100644
> > --- a/testcases/network/stress/broken_ip/broken_ip-nexthdr
> > +++ b/testcases/network/stress/broken_ip/broken_ip-nexthdr
> > @@ -1,11 +1,12 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-or-later
> > -# Copyright (c) 2019 Petr Vorel <pvorel@suse.cz>
> > +# Copyright (c) 2019-2021 Petr Vorel <pvorel@suse.cz>
> > # Copyright (c) 2014-2017 Oracle and/or its affiliates. All Rights Reserved.
> > # Copyright (c) International Business Machines Corp., 2006
> > # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> > TST_TESTFUNC="do_test"
> > +TST_NET_IPV6_ONLY=1
> +TST_IPV6=6 won't work to fix #843?
> > . tst_net.sh
> > do_test()
> > diff --git a/testcases/network/stress/broken_ip/broken_ip-protcol b/testcases/network/stress/broken_ip/broken_ip-protcol
> > index a91cdaaeb..9f9275f03 100644
> > --- a/testcases/network/stress/broken_ip/broken_ip-protcol
> > +++ b/testcases/network/stress/broken_ip/broken_ip-protcol
> > @@ -1,11 +1,12 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-or-later
> > -# Copyright (c) 2019 Petr Vorel <pvorel@suse.cz>
> > +# Copyright (c) 2019-2021 Petr Vorel <pvorel@suse.cz>
> > # Copyright (c) 2014-2017 Oracle and/or its affiliates. All Rights Reserved.
> > # Copyright (c) International Business Machines Corp., 2006
> > # Author: Mitsuru Chinen <mitch@jp.ibm.com>
> > TST_TESTFUNC="do_test"
> > +TST_NET_IPV4_ONLY=1
> > . tst_net.sh
> > do_test()
> The generic version looks fine:
> Reviewed-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
I didn't understand whether you'd prefer to add TST_IPV6=6 (or TST_IPV6=) where
needed or accept this patchset. Both would work.
Kind regards,
Petr
next prev parent reply other threads:[~2021-07-27 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:07 [LTP] [PATCH 0/2] Add TST_NET_IPV{4,6}_ONLY and use on broken_ip Petr Vorel
2021-07-14 14:07 ` [LTP] [PATCH 1/2] tst_net.sh: Add variable for supported protocol Petr Vorel
2021-07-14 14:07 ` [LTP] [PATCH 2/2] broken_ip: TCONF when test run on unsupported protocol Petr Vorel
2021-07-15 9:53 ` Alexey Kodanev
2021-07-15 12:07 ` Petr Vorel
2021-07-27 17:35 ` Petr Vorel [this message]
2021-07-28 11:20 ` Alexey Kodanev
2021-07-28 13:08 ` Petr Vorel
2021-08-02 18:06 ` Petr Vorel
2021-08-03 10:31 ` Alexey Kodanev
2021-08-03 15:37 ` Petr Vorel
2021-08-03 16:22 ` Petr Vorel
2021-07-15 9:38 ` [LTP] [PATCH 0/2] Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip Alexey Kodanev
2021-07-15 11:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQBD4w2nKwY2G1l+@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox