From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] ipsec_lib.sh: check ip_vti/ip6_vti are enabled or skip tests
Date: Fri, 30 Jul 2021 09:08:31 +0200 [thread overview]
Message-ID: <YQOlbyslKEiw9rCx@pevik> (raw)
In-Reply-To: <20210728140453.23356-1-radoslav.kolev@suse.com>
Hi Radoslav,
...
> + if [ "$TST_IPV6" ]; then
> + tst_net_run -q "tst_check_drivers ip6_vti" || \
> + tst_brk TCONF "ip6_vti driver not available on lhost or rhost"
> + else
> + tst_net_run -q "tst_check_drivers ip_vti" || \
> + tst_brk TCONF "ip_vti driver not available on lhost or rhost"
> + fi
nit: broken indentation, but that'll be fix during merge.
LGTM, but I'm going to merge shorter version (we have $TST_IPV6 for this
purpose).
tst_net_run -q "tst_check_drivers ip${TST_IPV6}_vti" || \
tst_brk TCONF "ip${TST_IPV6}_vti driver not available on lhost or rhost"
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2021-07-30 7:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 6:34 [LTP] [PATCH v1] lib/tst_test.sh: skip test if ip returns "Error: Unknown device type" Radoslav Kolev
2021-07-22 7:49 ` Petr Vorel
2021-07-27 8:20 ` Radoslav Kolev
2021-07-27 8:44 ` Alexey Kodanev
2021-07-27 10:02 ` Petr Vorel
2021-07-28 11:38 ` Alexey Kodanev
2021-07-28 13:06 ` Petr Vorel
2021-07-28 14:00 ` Radoslav Kolev
2021-07-28 14:04 ` [LTP] [PATCH v2] ipsec_lib.sh: check ip_vti/ip6_vti are enabled or skip tests Radoslav Kolev
2021-07-30 7:08 ` Petr Vorel [this message]
2021-07-30 7:50 ` Alexey Kodanev
2021-07-30 9:45 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQOlbyslKEiw9rCx@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox