From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] squashfs: Add regression test for sanity check bug
Date: Wed, 4 Aug 2021 16:05:26 +0200 [thread overview]
Message-ID: <YQqepmX0gmdpSqn5@yuki> (raw)
In-Reply-To: <20210715050812.1950884-1-lkml@jv-coder.de>
Hi!
Pushed with minor changes, thanks.
Apart from removing the needs_tmpdir I've also changed the TPASS message
to something more meaningful and move the TINFO message to setup so that
it's not printed on each iteration.
Full diff:
diff --git a/testcases/kernel/fs/squashfs/squashfs01.c b/testcases/kernel/fs/squashfs/squashfs01.c
index f02c91f83..502de419d 100644
--- a/testcases/kernel/fs/squashfs/squashfs01.c
+++ b/testcases/kernel/fs/squashfs/squashfs01.c
@@ -51,6 +51,8 @@ static void setup(void)
{
int i;
+ tst_res(TINFO, "Test squashfs sanity check regressions");
+
SAFE_MKDIR(DATA_DIR, 0777);
for (i = 0; i < 2048; ++i) {
@@ -85,8 +87,6 @@ static void setup(void)
static void run(void)
{
- tst_res(TINFO, "Test squashfs sanity check regressions");
-
if (mount(tst_device->dev, MOUNT_DIR, "squashfs", 0, NULL) != 0)
tst_brk(TFAIL | TERRNO, "Mount failed");
mounted = 1;
@@ -94,7 +94,7 @@ static void run(void)
SAFE_UMOUNT("mnt");
mounted = 0;
- tst_res(TPASS, "Test passed");
+ tst_res(TPASS, "Regression not detected");
}
static struct tst_test test = {
@@ -117,5 +117,4 @@ static struct tst_test test = {
{"linux-git", "8b44ca2b634"},
{}
},
- .needs_tmpdir = 1,
};
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2021-08-04 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 5:08 [LTP] [PATCH v3] squashfs: Add regression test for sanity check bug Joerg Vehlow
2021-07-15 8:00 ` Richard Palethorpe
2021-07-15 8:21 ` xuyang2018.jy
2021-07-15 8:44 ` Joerg Vehlow
2021-07-15 9:27 ` Cyril Hrubis
2021-07-15 10:12 ` Joerg Vehlow
2021-07-15 10:09 ` Cyril Hrubis
2021-07-15 10:40 ` Joerg Vehlow
2021-07-21 11:47 ` Cyril Hrubis
2021-08-04 14:05 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQqepmX0gmdpSqn5@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox