public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [2/6] syscalls/sysfs: Convert sysfs02 to the new API
Date: Thu, 5 Aug 2021 14:00:28 +0200	[thread overview]
Message-ID: <YQvS3PLdmpmSNJAf@yuki> (raw)
In-Reply-To: <20210805104229.10826-1-sujiaxun@uniontech.com>

Hi!
> +/*
> + * [DESCRIPTION]

This has to be [Description]

> -		TEST(ltp_syscall(__NR_sysfs, 2, 0, buf));
> +		TEST(tst_syscall(__NR_sysfs, 2, 0, buf));
> 
>  		/* check return code */
> -		if (TEST_RETURN == -1) {
> -			tst_resm(TFAIL, "sysfs(2) Failed for "
> +		if (TST_RET == -1) {
> +			tst_res(TFAIL, "sysfs(2) Failed for "
>  				 "option 2 and returned"
> -				 " %d as error number", TEST_ERRNO);
> +				 " %d as error number", TST_ERR);
>  		} else {
> -			tst_resm(TPASS, "sysfs(2) Passed for option 2");
> +			tst_res(TPASS, "sysfs(2) Passed for option 2");
>  		}
> -	}			/*End of TEST_LOOPING */

And this should be just TST_EXP_PASS(...);


-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2021-08-05 12:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 10:42 [LTP] [PATCH] [2/6] syscalls/sysfs: Convert sysfs02 to the new API sujiaxun
2021-08-05 12:00 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQvS3PLdmpmSNJAf@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox