public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [3/6] syscalls/sysfs: Convert sysfs03 to the new API
Date: Thu, 5 Aug 2021 14:04:54 +0200	[thread overview]
Message-ID: <YQvT5slxDpsJtSDc@yuki> (raw)
In-Reply-To: <20210805110349.16615-1-sujiaxun@uniontech.com>

Hi!
> +/*
> + * [DESCRIPTION]

Here as well [Description]

> + * This test is run for option 3 for sysfs(2)
> + */
> 
>  #include <errno.h>
>  #include <unistd.h>
>  #include <sys/syscall.h>
> -#include "test.h"
> +#include "tst_test.h"
>  #include "lapi/syscalls.h"
> 
> -static void setup();
> -static void cleanup();
> -
> -char *TCID = "sysfs03";
> -int TST_TOTAL = 1;
> -
> -int main(int ac, char **av)
> +static void verify_sysfs03(void)
>  {
> -	int lc;
> -
> -	tst_parse_opts(ac, av, NULL, NULL);
> 
> -	setup();
> 
> -	for (lc = 0; TEST_LOOPING(lc); lc++) {
> -
> -		tst_count = 0;
> -
> -		TEST(ltp_syscall(__NR_sysfs, 3));
> +		TEST(tst_syscall(__NR_sysfs, 3));
> 
>  		/* check return code */
> -		if (TEST_RETURN == -1) {
> -			tst_resm(TFAIL, "sysfs(2) Failed for"
> +		if (TST_RET == -1) {
> +			tst_res(TFAIL, "sysfs(2) Failed for"
>  				 " option 3 and returned"
> -				 " %d as error number", TEST_ERRNO);
> +				 " %d as error number", TST_ERR);
>  		} else {
> -			tst_resm(TPASS, "sysfs(2) Passed for option 3");
> +			tst_res(TPASS, "sysfs(2) Passed for option 3");
>  		}
> -	}			/*End of TEST_LOOPING */

And here as well this could be replaced with TST_EXP_POSSITIVE()


-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2021-08-05 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 11:03 [LTP] [PATCH] [3/6] syscalls/sysfs: Convert sysfs03 to the new API sujiaxun
2021-08-05 12:04 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQvT5slxDpsJtSDc@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox