public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib
Date: Fri, 20 Aug 2021 12:59:14 +0200	[thread overview]
Message-ID: <YR+LAmVDEUcZ51Wt@pevik> (raw)
In-Reply-To: <20210812043807.3497492-1-lkml@jv-coder.de>

Hi Joerg,

LGTM, good idea.

But I'd rename $LTP_IPC_PATH to $TST_IPC_PATH to follow conventions to new API
(There are also some LTP_* definitions in the legacy C API which were renamed as
TST_* in the new API).


> +	if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "${LTP_IPC_PATH}" ]; then
nit (remove unnecessary {}):
    if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "$TST_IPC_PATH" ]; then
> +		rm ${LTP_IPC_PATH}
and here:
		rm $TST_IPC_PATH

Kind regards,
Petr

  parent reply	other threads:[~2021-08-20 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12  4:38 [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib Joerg Vehlow
2021-08-12  4:38 ` [LTP] [PATCH v2 2/2] pec: Improve reliability Joerg Vehlow
2021-08-20 11:01   ` Petr Vorel
2021-08-23  4:31     ` Joerg Vehlow
2021-08-24  6:29       ` Petr Vorel
2021-08-24  7:27         ` Joerg Vehlow
2021-08-24 10:47           ` Petr Vorel
2021-08-20 10:59 ` Petr Vorel [this message]
2021-08-23  4:36   ` [LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib Joerg Vehlow
2021-08-24  5:47     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR+LAmVDEUcZ51Wt@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox