[LTP] [PATCH] [v2, 1/6] syscalls/sysfs: Convert sysfs01 to the new API

sujiaxun
2021-08-11T02:45:58Z

? 2021/8/10 ??9:54, Cyril Hrubis ??:
> Hi!
>> I checked with "checkpatch.pl -f" and there were no errors or warnings.
>> I use "git am" to apply the patch normally without any warning. How did
>> you check that there are spaces.
>
> Have you used recent enough version?
>
> Latest kernel git:
>
> $ ~/linux/scripts/checkpatch.pl -f sysfs01.c
>
> ERROR: code indent should use tabs where possible
> #20: FILE: sysfs01.c:20:
> + /* option 1, buf holds fs name */$
>
> ERROR: code indent should use tabs where possible
> #21: FILE: sysfs01.c:21:
> + TST_EXP_POSITIVE(tst_syscall(__NR_sysfs, 1, "proc"),$
>
> WARNING: please, no spaces at the start of a line
> #21: FILE: sysfs01.c:21:
> + TST_EXP_POSITIVE(tst_syscall(__NR_sysfs, 1, "proc"),$
>
> ERROR: code indent should use tabs where possible
> #22: FILE: sysfs01.c:22:
> + "sysfs(1,'proc')");$
>
> WARNING: please, no spaces at the start of a line
> #22: FILE: sysfs01.c:22:
>
> ...
>
>
> $ cd ~/linux/; git describe
>
> v5.14-rc5-2-g9a73fa375d58
>
Thank you, the kernel version I use is v4.19.90. But it may have nothing
to do with the version. I only use "checkpatch.pl -f X.patch" instead of
"checkpatch.pl -f sysfs01.c". I have revised the check again and will
resubmit.
--
Kind regards,

sujiaxun