public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] commands: Drop which01.sh
Date: Wed, 18 Aug 2021 12:01:35 +0200	[thread overview]
Message-ID: <YRzaf3jq02zM306Y@pevik> (raw)
In-Reply-To: <8589e81b-4c45-e62e-297a-ef6a3cd548dc@jv-coder.de>

Hi Joerg,

> Hi Petr,

> On 8/18/2021 11:12 AM, Petr Vorel wrote:
> > "which" has been discontinued after 2.21 release in 2015 due this (git
> > repository is empty [1]).
> I am a bit against dropping this. which is widely used and I think as long
> as it is available, it should behave as expected.
First, thanks for your review of all patchset.

I should have marked this commit as RFC. I have no problem to postpone
deleting this test fairly long time (even for 1-2 years).

But, if we really want to test basic shell commands (IMHO they should be part of
particular shell implementation code and most of these projects have it: e.g.
bash, busybox, coreutils, util-linux, ...), in this particular test it'd be more
useful to test "type" or "command" than "which", which code hasn't been changed
since 2015. Looking into openSUSE code [1], there is no patch on "which"
command.

Also, I might be a bit too aggressive when removing tests for legacy code, but
in this case Debian has deprecated "which" from it's basic tools [2], proving
there is a push to use "type" / "command -v" at least in some distros.

Kind regards,
Petr

[1] https://build.opensuse.org/package/show/Base:System/which
[2] https://salsa.debian.org/debian/debianutils/-/commit/3a8dd10b4502f7bae8fc6973c13ce23fc9da7efb

  reply	other threads:[~2021-08-18 10:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18  9:12 [LTP] [PATCH 0/3] shell: remove which, use type or command -v Petr Vorel
2021-08-18  9:12 ` [LTP] [PATCH 1/3] tst_test.sh: Simplify tst_cmd_available() Petr Vorel
2021-08-18  9:30   ` Joerg Vehlow
2021-08-18  9:40     ` Petr Vorel
2021-08-19  3:59       ` Li Wang
2021-08-19  6:09         ` Petr Vorel
2021-08-20  9:28         ` Petr Vorel
2021-08-18  9:12 ` [LTP] [PATCH 2/3] binfmt_misc02.sh: Use "command -v" instead of "which" Petr Vorel
2021-08-18  9:31   ` Joerg Vehlow
2021-08-18  9:42     ` Petr Vorel
2021-08-18  9:12 ` [LTP] [PATCH 3/3] commands: Drop which01.sh Petr Vorel
2021-08-18  9:32   ` Joerg Vehlow
2021-08-18 10:01     ` Petr Vorel [this message]
2021-08-19  5:49       ` Li Wang
2021-08-19  6:04         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRzaf3jq02zM306Y@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox