From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/pread01: Convert to new API
Date: Wed, 1 Sep 2021 16:08:00 +0200 [thread overview]
Message-ID: <YS+JQLNhte4E3jxM@pevik> (raw)
In-Reply-To: <1629294657-28375-1-git-send-email-daisl.fnst@fujitsu.com>
Hi Dai,
> diff --git a/testcases/kernel/syscalls/pwrite/pwrite01.c b/testcases/kernel/syscalls/pwrite/pwrite01.c
...
> -/*
> - * Test Name: pwrite01
> +/*\
> + * [Description]
> *
> - * Test Description:
> * Verify the functionality of pwrite() by writing known data using pwrite()
> * to the file at various specified offsets and later read from the file from
> * various specified offsets, comparing the data written aganist the data
> * read using read().
You kept 2 spaces between * and text. That'll lead in docparse formatting (which
uses markdown) to formatted as code, which is wrong. It must be without space:
/*\
* [Description]
*
* Verify the functionality of pwrite() by writing known data using pwrite()
* to the file at various specified offsets and later read from the file from
* various specified offsets, comparing the data written aganist the data
* read using read().
*/
Again, I have already prepared fixes, just wait for others to review.
Kind regards,
Petr
next prev parent reply other threads:[~2021-09-01 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 13:50 [LTP] [PATCH] syscalls/pread01: Convert to new API Dai Shili
2021-09-01 13:19 ` Petr Vorel
2021-09-01 13:53 ` Petr Vorel
2021-09-01 13:48 ` Petr Vorel
2021-09-01 14:08 ` Petr Vorel [this message]
2021-09-02 1:17 ` xuyang2018.jy
2021-09-02 16:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS+JQLNhte4E3jxM@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox