From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Bobrowski Date: Mon, 23 Aug 2021 21:19:22 +1000 Subject: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR In-Reply-To: <20210823093524.GB21467@quack2.suse.cz> References: <20210802214645.2633028-1-krisman@collabora.com> <20210802214645.2633028-4-krisman@collabora.com> <87fsvphksu.fsf@collabora.com> <20210823093524.GB21467@quack2.suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On Mon, Aug 23, 2021 at 11:35:24AM +0200, Jan Kara wrote: > On Sat 21-08-21 07:58:07, Matthew Bobrowski wrote: > > On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote: > > > Hi all, > > > > > > > No problem. That's what review is for ;-) > > > > > > > BTW, unless anyone is specifically interested I don't think there > > > > is a reason to re post the test patches before the submission request. > > > > Certainly not for the small fixes that I requested. > > > > > > > I do request that you post a link to a branch with the fixed test > > > > so that we can experiment with the kernel patches. > > > > > > > I've also CC'ed Matthew who may want to help with review of the test > > > > and man page that you posted in the cover letter [1]. > > > > > > @Amir Thanks a lot for your review, agree with all you mentioned. > > > > > > @Gabriel Thanks for your contribution. I'd also consider squashing some of the > > > commits. > > > > Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so, > > I may need to do some shuffling around as these LTP tests collide with the > > ones I author for the FAN_REPORT_PIDFD series. > > No, I don't think FAN_FS_ERROR is quite ready for the coming merge window. > So you should be fine. Alrighty, thanks for letting me know Jan. /M