[LTP] [PATCH v2 1/2] shell: Add checkpoints api for new lib

Joerg Vehlow
2021-08-23T04:36:05Z

Hi Petr,

On 8/20/2021 12:59 PM, Petr Vorel wrote:
> Hi Joerg,
>
> LGTM, good idea.
>
> But I'd rename $LTP_IPC_PATH to $TST_IPC_PATH to follow conventions to new API
> (There are also some LTP_* definitions in the legacy C API which were renamed as
> TST_* in the new API).
This would also require changing the C API, because the environment
variable is used for communicating with it.
I we want this, I guess it could be done in another changeset.
>
>
>> + if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "${LTP_IPC_PATH}" ]; then
> nit (remove unnecessary {}):
Could be changed while merging.
> if [ -n "$TST_NEEDS_CHECKPOINTS" -a -f "$TST_IPC_PATH" ]; then
>> + rm ${LTP_IPC_PATH}
> and here:
> rm $TST_IPC_PATH
>

Joerg