From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] network/tst_net.sh: fix busybox/sysctl in tst_set_sysctl()
Date: Tue, 24 Aug 2021 14:11:24 +0200 [thread overview]
Message-ID: <YSTh7DeKY5J0SSyv@pevik> (raw)
In-Reply-To: <48500320-6cc6-591a-fc3d-708e88fd8640@bell-sw.com>
Hi Alexey,
..
> >> - tst_net_run $safe $rparam "sysctl -q -w $name=$value"
> >> + tst_net_run $safe $rparam "sysctl -q -w" "$name=$value"
> > I wonder if it were a bit clearer if we moves all params to second arg:
> > tst_net_run $safe "sysctl" "$name=$value -q -w"
> OK, but changed to "sysctl" "-q -w $name=$value" because the other
> options should also be placed before the key/value pair:
> Usage: sysctl -p [-enq] [FILE...] / [-enqaw] [KEY[=VALUE]]...
Thanks for addressing it!
Kind regards,
Petr
next prev parent reply other threads:[~2021-08-24 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 12:04 [LTP] [PATCH 1/3] network/tcp_cc: check sch_netem driver in the lib Alexey Kodanev
2021-08-04 12:04 ` [LTP] [PATCH 2/3] network/tst_net.sh: fix busybox/sysctl in tst_set_sysctl() Alexey Kodanev
2021-08-20 10:43 ` Petr Vorel
2021-08-24 11:35 ` Alexey Kodanev
2021-08-24 12:11 ` Petr Vorel [this message]
2021-08-04 12:04 ` [LTP] [PATCH 3/3] network/tst_net.sh: extend the pattern in tst_ping_opt_unsupported() Alexey Kodanev
2021-08-20 10:46 ` Petr Vorel
2021-08-20 11:28 ` Alexey Kodanev
2021-08-20 12:29 ` Petr Vorel
2021-08-20 10:37 ` [LTP] [PATCH 1/3] network/tcp_cc: check sch_netem driver in the lib Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSTh7DeKY5J0SSyv@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox