From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/3] New API: Rename LTP_IPC_PATH -> TST_IPC_PATH
Date: Wed, 25 Aug 2021 11:09:11 +0200 [thread overview]
Message-ID: <YSYIt9TqTBU0AVKk@pevik> (raw)
In-Reply-To: <YSYGy3cewt9Sseb/@yuki>
> Hi!
> > Petr Vorel (3):
> > lib: Move IPC_ENV_VAR definition into header
> > C API: Rename LTP_IPC_PATH -> TST_IPC_PATH
> > shell API: Rename LTP_IPC_PATH -> TST_IPC_PATH
> Is this really a good idea?
> As it is it's pretty clear where the environment variable comes from, if
> we rename it to TST_IPC_PATH it's not obvious that this has been
> exported by LTP test.
I was thinking about it as well (just forget to write that into cover letter).
> Generally things that are visible on the running system tends to be
> prefixed with LTP_ or ltp_ rather than TST_ or tst_...
Sure. I just thought that LTP_ is for variables which are expected to be set by
user. But let's keep the old name. How about the first commit (cleanup)?
Kind regards,
Petr
[1] https://github.com/linux-test-project/ltp/wiki/User-Guidelines
next prev parent reply other threads:[~2021-08-25 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 8:09 [LTP] [PATCH 0/3] New API: Rename LTP_IPC_PATH -> TST_IPC_PATH Petr Vorel
2021-08-25 8:09 ` [LTP] [PATCH 1/3] lib: Move IPC_ENV_VAR definition into header Petr Vorel
2021-08-25 9:21 ` Cyril Hrubis
2021-08-25 10:21 ` Petr Vorel
2021-08-25 8:09 ` [LTP] [PATCH 2/3] C API: Rename LTP_IPC_PATH -> TST_IPC_PATH Petr Vorel
2021-08-25 8:15 ` Joerg Vehlow
2021-08-25 9:00 ` Petr Vorel
2021-08-25 9:08 ` Joerg Vehlow
2021-08-25 8:09 ` [LTP] [PATCH 3/3] shell " Petr Vorel
2021-08-25 8:18 ` Joerg Vehlow
2021-08-25 9:04 ` Petr Vorel
2021-08-25 9:00 ` [LTP] [PATCH 0/3] New " Cyril Hrubis
2021-08-25 9:09 ` Petr Vorel [this message]
2021-08-25 9:20 ` Cyril Hrubis
2021-08-25 10:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSYIt9TqTBU0AVKk@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox