public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] Add CHECK_NOFLAGS and checkpatch.pl to 'make check'
Date: Fri, 27 Aug 2021 14:15:27 +0200	[thread overview]
Message-ID: <YSjXX6NWbDzu5X9m@pevik> (raw)
In-Reply-To: <20210827095210.23602-2-rpalethorpe@suse.com>

Hi Richie,

> Add another check command type. CHECK_NOFLAGS just takes the source
> file name as an argument. By default it is set to
> scripts/checkpatch.pl which is probably the only thing we want to use
> it for. OTOH you can set it to clang-tidy instead.
The same we could do with checkbashisms for tests using new shell API.

> It is run with '-' because of the large number of errors it presently
> produces. Also of course, check errors are not actually fatal. If we
> wish to stop on errors in the future (e.g. for CI) then a "strict"
> option can be introduced.

Thanks for doing this!

Could it be possible to run it only for tests which use new API? Otherwise it
takes long time before we can use it in CI due lots of output from tests using
legacy API:

tst_record_childstatus.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
=> tst_record_childstatus.c uses test.h.

Kind regards,
Petr

  reply	other threads:[~2021-08-27 12:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27  9:52 [LTP] [PATCH 1/2] Vendor checkpatch.pl from kernel next-20210826 Richard Palethorpe
2021-08-27  9:52 ` [LTP] [PATCH 2/2] Add CHECK_NOFLAGS and checkpatch.pl to 'make check' Richard Palethorpe
2021-08-27 12:15   ` Petr Vorel [this message]
2021-08-30 13:33     ` Cyril Hrubis
2021-08-30 16:56       ` Petr Vorel
2021-08-30 17:49       ` Petr Vorel
2021-08-31  8:41   ` Cyril Hrubis
2021-08-31 12:05     ` Petr Vorel
2021-08-27 12:09 ` [LTP] [PATCH 1/2] Vendor checkpatch.pl from kernel next-20210826 Petr Vorel
2021-08-31  8:38 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSjXX6NWbDzu5X9m@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox