From: Petr Vorel <pvorel@suse.cz>
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 5/6] rt:pi-tests:testpi-5: return exit code
Date: Fri, 24 Sep 2021 11:53:06 +0200 [thread overview]
Message-ID: <YU2gAiF7HGujCv+n@pevik> (raw)
In-Reply-To: <20210914170851.22931-5-bogdan.lezhepekov@suse.com>
Hi Bogdan,
> +++ b/testcases/realtime/func/pi-tests/testpi-5.c
...
> create_other_thread(child_thread, NULL);
> join_threads();
> - return 0;
> + return err > 0 ? 1: 0;
nit: "1: 0" => "1 : 0" (for better readability).
Whole patchset LGTM, thanks for improving realtime tests.
To whole patchset:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-24 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 17:08 [LTP] [PATCH v1 1/6] realtime:async_handler_jk: return actual exit code Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
2021-09-14 17:08 ` [LTP] [PATCH v1 2/6] rt:pi-tests::sbrk_mutex: " Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
2021-09-24 15:33 ` Cyril Hrubis
2021-09-14 17:08 ` [LTP] [PATCH v1 3/6] rt:pi-tests:testpi-0: " Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
2021-09-14 17:08 ` [LTP] [PATCH v1 4/6] rt:pi-tests:test-skeleton: fix wrong return value Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
2021-09-14 17:08 ` [LTP] [PATCH v1 5/6] rt:pi-tests:testpi-5: return exit code Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
2021-09-24 9:53 ` Petr Vorel [this message]
2021-09-24 10:07 ` Bogdan Lezhepekov via ltp
2021-09-14 17:08 ` [LTP] [PATCH v1 6/6] rt:pi-tests:testpi-6: " Bogdan Lezhepekov
2021-09-14 17:08 ` Bogdan Lezhepekov via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU2gAiF7HGujCv+n@pevik \
--to=pvorel@suse.cz \
--cc=bogdan.lezhepekov@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox