Re: [LTP] [PATCH] [RFC] lib: shell: Fix timeout process races

Li Wang
2021-09-21T03:46:28Z

[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

Hi Joerg,

On Mon, Sep 20, 2021 at 3:36 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > There were actually several races in the shell library timeout
> handling.
> > >
> > > This commit fixes hopefully all of them by:
> > >
> > > * Reimplementing the backgroud timer in C
> > I did that once, but at that point it was kinda rejected ;)
>

Sorry, I was suggesting to solve the problem only in Shell ATM,
and it proved that it's not easy to cover all.

> > See https://lists.linux.it/pipermail/ltp/2021-May/022445.html
> > and https://lists.linux.it/pipermail/ltp/2021-May/022453.html
>
> I guess we found out the hard way that it's impossible to write raceless
> timeouts in shell.

+1 Indeed.

--
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1834 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]