From: Cyril Hrubis <chrubis@suse.cz>
To: Joerg Vehlow <lkml@jv-coder.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] [RFC] lib: shell: Fix timeout process races
Date: Mon, 20 Sep 2021 14:02:22 +0200 [thread overview]
Message-ID: <YUh4TsjTZeFh/UYO@yuki> (raw)
In-Reply-To: <YUg6BM39OKgI5Ovl@yuki>
Hi!
> > Shouldn't this be reused from the library instead of being reimplemented?
>
> I wanted to avoid calling the tst_res() functions to keep things simple,
> but I guess that there is no reason not to use it.
And there actuall was a reason, since we cannot do tst_res(TBROK,
"..."); in the C library.
And looking at the C library, we avoid using the tst_res() on timeouts
as well, actually we just write to stderr because we do that from a
signal handler context. So I guess that we can just print to stderr here
instead.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-20 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 14:17 [LTP] [PATCH] [RFC] lib: shell: Fix timeout process races Cyril Hrubis
2021-09-17 14:17 ` Cyril Hrubis
2021-09-20 4:51 ` Joerg Vehlow
2021-09-20 7:36 ` Cyril Hrubis
2021-09-20 12:02 ` Cyril Hrubis [this message]
2021-09-21 3:45 ` Li Wang
2021-09-20 7:52 ` Petr Vorel
2021-09-20 7:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUh4TsjTZeFh/UYO@yuki \
--to=chrubis@suse.cz \
--cc=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox