From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [RFC PATCH] fallocate05: increase the fallocate and defallocate size
Date: Wed, 22 Sep 2021 10:21:42 +0200 [thread overview]
Message-ID: <YUrnljqYd5Hx/fi+@yuki> (raw)
In-Reply-To: <CAEemH2dMCmYDkZYxfaeJ_oQCCcHzeMgSOGVQ_wS6BwCrp0YiQw@mail.gmail.com>
Hi!
> > This change appears seems to be causing fallocate05 test to reliably
> > trigger OOM (out of memory) on my test machine, which has only 256MB
> > RAM.
> >
>
> Thanks for reporting the failure. We purposely increase the size of
> fallocate
> to reduce interference from metadata changing. But not clear how much
> size should be a proper value for a small system.
>
> Can you try with decrease the number of FALLOCATE_BLOCKS?
>
> i.e.
>
> #define FALLOCATE_BLOCKS 64
> #define DEALLOCATE_BLOCKS 16
>
> Or, what about other multiple sizes, test result?
Looking at the test I do not think there is a reason to allocate more
than a two or four blocks for the buffer. We just need to write() to the
fallocated area in a loop one block at a time until it's full. I do not
think that it's a good idea to pass ~100MB buffer to a single write()
and expect it to succeed anyways.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-22 8:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 10:46 [LTP] [RFC PATCH] fallocate05: increase the fallocate and defallocate size Li Wang
2021-09-07 2:40 ` Li Wang
2021-09-07 2:40 ` Li Wang
2021-09-07 8:00 ` Jan Stancek
2021-09-07 8:00 ` Jan Stancek
2021-09-08 1:21 ` Li Wang
2021-09-08 1:21 ` Li Wang
2021-09-21 20:33 ` Ralph Siemsen
2021-09-22 5:03 ` Li Wang
2021-09-22 8:21 ` Cyril Hrubis [this message]
2021-09-22 9:53 ` Li Wang
2021-09-22 9:56 ` Cyril Hrubis
2021-09-22 10:34 ` Li Wang
2021-09-22 14:32 ` Cyril Hrubis
2021-09-22 16:52 ` Ralph Siemsen
2021-09-23 3:00 ` Li Wang
2021-09-23 6:29 ` Li Wang
2021-09-23 13:09 ` Cyril Hrubis
2021-09-24 4:27 ` Li Wang
2021-09-23 14:33 ` Cyril Hrubis
2021-09-24 1:49 ` Ralph Siemsen
2021-09-24 4:18 ` Li Wang
2021-09-24 15:11 ` Ralph Siemsen
2021-09-24 18:26 ` Cyril Hrubis
2021-09-24 20:26 ` Ralph Siemsen
2021-09-25 2:16 ` Ralph Siemsen
2021-09-26 7:17 ` Li Wang
2021-09-26 7:40 ` Li Wang
2021-09-26 7:39 ` Li Wang
2021-09-27 1:37 ` Ralph Siemsen
2021-09-24 6:49 ` Li Wang
2021-09-24 9:33 ` Cyril Hrubis
2021-09-23 6:39 ` Li Wang
2021-09-23 13:10 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUrnljqYd5Hx/fi+@yuki \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox