From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A997AC433F5 for ; Wed, 22 Sep 2021 08:21:27 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 768A661184 for ; Wed, 22 Sep 2021 08:21:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 768A661184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id AB7B03CA1FE for ; Wed, 22 Sep 2021 10:21:22 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9AFD03C6A0B for ; Wed, 22 Sep 2021 10:21:13 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D70F12000AB for ; Wed, 22 Sep 2021 10:21:12 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D59221FF53; Wed, 22 Sep 2021 08:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1632298871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gkj6GJEKEVMfodLQiKxIIKwPV7F+FgTn8XKKU4N+9nE=; b=fUUIA73+Oo8KH0ZHXRZeMPrFqCLMXTDUKdGHKfGoQXnXA4OpTWY35qGtDiDJKwEo/fNLEv gBHnQPN2KV3jVZmgoGshuNHGnM8TkwfLuWg3SX368FwTpf1e1UKRMzspViFuKsOR4+HK72 nfh3Wn8/XAVxdt9TIYFWAIWLDXgwe2Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1632298871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gkj6GJEKEVMfodLQiKxIIKwPV7F+FgTn8XKKU4N+9nE=; b=LE41HwH7uKGoBAzIFEQzl7Z6GZg7KGePfzNdLOd9W3Jd5ZyYb53mn3vEAHCpoJkVK7hTXi iRUkBPyfGD9fxLDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD03A13D65; Wed, 22 Sep 2021 08:21:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id o3kVLXfnSmHgCwAAMHmgww (envelope-from ); Wed, 22 Sep 2021 08:21:11 +0000 Date: Wed, 22 Sep 2021 10:21:42 +0200 From: Cyril Hrubis To: Li Wang Message-ID: References: <20210817104625.2559362-1-liwang@redhat.com> <20210921203349.GA2014441@maple.netwinder.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCH] fallocate05: increase the fallocate and defallocate size X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > This change appears seems to be causing fallocate05 test to reliably > > trigger OOM (out of memory) on my test machine, which has only 256MB > > RAM. > > > > Thanks for reporting the failure. We purposely increase the size of > fallocate > to reduce interference from metadata changing. But not clear how much > size should be a proper value for a small system. > > Can you try with decrease the number of FALLOCATE_BLOCKS? > > i.e. > > #define FALLOCATE_BLOCKS 64 > #define DEALLOCATE_BLOCKS 16 > > Or, what about other multiple sizes, test result? Looking at the test I do not think there is a reason to allocate more than a two or four blocks for the buffer. We just need to write() to the fallocated area in a loop one block at a time until it's full. I do not think that it's a good idea to pass ~100MB buffer to a single write() and expect it to succeed anyways. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp