From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: ltp@lists.linux.it, buildroot@buildroot.org
Subject: Re: [LTP] [RFC PATCH v2 1/3] tst_netdevice.c: Drop redundant include
Date: Wed, 6 Oct 2021 15:51:21 +0200 [thread overview]
Message-ID: <YV2p2ZT6o3IcaVIF@yuki> (raw)
In-Reply-To: <20210930183058.5240-2-petr.vorel@gmail.com>
Hi!
> <linux/rtnetlink.h> is already included in lapi/rtnetlink.h.
^
which includes <linux/netlink.h>
I suppose that you have tested this in CI and that it works fine. If
that is so:
Acked-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> lib/tst_netdevice.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/tst_netdevice.c b/lib/tst_netdevice.c
> index ba9a55b70..4a0442932 100644
> --- a/lib/tst_netdevice.c
> +++ b/lib/tst_netdevice.c
> @@ -4,7 +4,6 @@
> */
>
> #include <asm/types.h>
> -#include <linux/netlink.h>
> #include <linux/veth.h>
> #include <sys/socket.h>
> #include <net/if.h>
> --
> 2.33.0
>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-06 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 18:30 [LTP] [RFC PATCH v2 0/3] Fix old toolchain (< v3.14) Petr Vorel
2021-09-30 18:30 ` [LTP] [RFC PATCH v2 1/3] tst_netdevice.c: Drop redundant include Petr Vorel
2021-10-06 13:51 ` Cyril Hrubis [this message]
2021-09-30 18:30 ` [LTP] [RFC PATCH v2 2/3] lapi: Create if_addr.h and reuse it in rtnetlink.h Petr Vorel
2021-10-06 13:52 ` Cyril Hrubis
2021-09-30 18:30 ` [LTP] [RFC PATCH v2 3/3] lapi/if_addr.h: Define IFA_FLAGS Petr Vorel
2021-10-01 9:19 ` Martin Doucha
2021-10-02 17:23 ` Petr Vorel
2021-10-06 14:00 ` Cyril Hrubis
2021-10-06 19:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV2p2ZT6o3IcaVIF@yuki \
--to=chrubis@suse.cz \
--cc=buildroot@buildroot.org \
--cc=ltp@lists.linux.it \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox