From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] open_posix: remove pthread_kill/6-1
Date: Wed, 6 Oct 2021 16:31:13 +0200 [thread overview]
Message-ID: <YV2zMeb3ILLRPNsL@yuki> (raw)
In-Reply-To: <281d8fbf1a7df4d85aea6bbd3ff74982923309c5.1633527038.git.jstancek@redhat.com>
Hi!
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml
> index 2289b9bfbb2e..fa74c312bebb 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/assertions.xml
> @@ -16,10 +16,6 @@
> <assertion id="5" tag="ref:XSH6:33594:33595 pt:THR">
> No signal shall be sent if the pthread_kill() function fails.
> </assertion>
> - <assertion id="6" tag="ref:XSH6:33598:33599 pt:THR">
> - [ESRCH] No thread could be found corresponding to that specified by
> - the given thread ID.
> - </assertion>
> <assertion id="7" tag="ref:XSH6:33600:33600 pt:THR">
> [EINVAL] The value of the sig argument is an invalid or unsupported
> signal number.
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt
> index 03dc3d5a718a..8cfa3d8b6ba3 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_kill/coverage.txt
> @@ -6,6 +6,5 @@ Assertion Status
> 3 YES
> 4 IMPLICITLY tested by assertions 6 and 7.
> 5 IMPLICITLY tested by assertions 6 and 7.
> -6 YES
> 7 YES
> 8 WON'T test. No way to interrupt the pthread_kill() call.
Shouldn't we just flip the YES to WON'T test in the coverage?
I'm not sure how to maintain the assertions or coverage files to be
honest.
Otherwise it looks good. The ESRCH return was always a recommendation
and not an requirement.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-06 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 13:31 [LTP] [PATCH] open_posix: remove pthread_kill/6-1 Jan Stancek
2021-10-06 14:31 ` Cyril Hrubis [this message]
2021-10-06 14:58 ` Jan Stancek
2021-10-07 6:57 ` Cyril Hrubis
2021-10-07 14:22 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV2zMeb3ILLRPNsL@yuki \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox